Bug 205749

Summary: Crashes under -[WKWebView _addUpdateVisibleContentRectPreCommitHandler]_block_invoke
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, simon.fraser, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: commit-queue+

Tim Horton
Reported 2020-01-03 14:00:31 PST
Crashes under -[WKWebView _addUpdateVisibleContentRectPreCommitHandler]_block_invoke
Attachments
Patch (74.27 KB, patch)
2020-01-03 14:04 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (72.35 KB, patch)
2020-01-03 16:15 PST, Tim Horton 		thorton: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-01-03 14:04:16 PST
Created attachment 386714 [details] Patch
Tim Horton
Comment 2 2020-01-03 14:04:30 PST
<rdar://problem/56433624>
Simon Fraser (smfr)
Comment 3 2020-01-03 14:39:17 PST
Comment on attachment 386714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386714&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3578 > + RetainPtr<WKContentView> view = retainPtr(self); > + RetainPtr<WKWebView> webView = _webView.get(); Undo this part > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6020 > + [presentingViewController.transitionCoordinator animateAlongsideTransition:nil completion:[weakWebView = WeakObjCPtr<WKWebView>(self.webView), controller = _presentedFullScreenInputViewController] (id <UIViewControllerTransitionCoordinatorContext>) { Can we just copy the weak ptr? > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6041 > + [[presentedController transitionCoordinator] animateAlongsideTransition:nil completion:[weakWebView = WeakObjCPtr<WKWebView>(self.webView), controller = presentedController] (id <UIViewControllerTransitionCoordinatorContext>) { Ditto
Tim Horton
Comment 4 2020-01-03 16:15:02 PST
Created attachment 386725 [details] Patch
Tim Horton
Comment 5 2020-01-03 17:58:16 PST
https://trac.webkit.org/changeset/254025/webkit
Note You need to log in before you can comment on or make changes to this bug.