Bug 205730

Summary: [Apple Pay] Provide a better error message when Apple Pay blocks user agent script evaluation
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2020-01-03 09:54:20 PST
[Apple Pay] Provide a better error message when Apple Pay blocks user agent script evaluation
Attachments
Patch (8.87 KB, patch)
2020-01-03 09:55 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (8.94 KB, patch)
2020-01-03 10:54 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2020-01-03 09:55:55 PST
Created attachment 386692 [details] Patch
Brady Eidson
Comment 2 2020-01-03 10:51:12 PST
Comment on attachment 386692 [details] Patch Andy and I discussed some refinements to the error message text IRL.
Alex Christensen
Comment 3 2020-01-03 10:52:19 PST
Comment on attachment 386692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386692&action=review > Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.cpp:162 > + return "Unable to run user agent scripts because this document uses Apple Pay. Apple Pay can be disabled in this web view by injecting a WKUserScript."_s; This is confusing. It seems like it's unable to run scripts because of Apple Pay, but running scripts can disable Apple Pay. "user agent scripts" is unclear. I think what you're trying to say is that to run scripts using evaluteJavaScript on pages that try to use Apple Pay, use WKUserScripts to disable Apple Pay. Is that correct?
Andy Estes
Comment 4 2020-01-03 10:54:18 PST
Created attachment 386698 [details] Patch
Andy Estes
Comment 5 2020-01-03 10:56:03 PST
(In reply to Alex Christensen from comment #3) > Comment on attachment 386692 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386692&action=review > > > Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.cpp:162 > > + return "Unable to run user agent scripts because this document uses Apple Pay. Apple Pay can be disabled in this web view by injecting a WKUserScript."_s; > > This is confusing. It seems like it's unable to run scripts because of > Apple Pay, but running scripts can disable Apple Pay. "user agent scripts" > is unclear. It was confusing :( > I think what you're trying to say is that to run scripts using > evaluteJavaScript on pages that try to use Apple Pay, use WKUserScripts to > disable Apple Pay. Is that correct? That's correct.
Andy Estes
Comment 6 2020-01-03 11:01:40 PST
Posted a new patch with the refinements Brady suggested.
Andy Estes
Comment 7 2020-01-03 14:30:17 PST
Committed r254015: <https://trac.webkit.org/changeset/254015>
Radar WebKit Bug Importer
Comment 8 2020-01-03 14:31:19 PST
<rdar://problem/58307301>
Note You need to log in before you can comment on or make changes to this bug.