Bug 205716 – [GTK][WPE] Add API to retrieve and delete surrounding text for input methods

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

.

[Carlos Garcia Campos]

Created attachment 386674 [details]
Patch

[Zan Dobersek]

Comment on attachment 386674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386674&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitInputMethodContextImplGtk.cpp:32
> +    unsigned surroundingCursorIndex;

Maybe explicitly initialize this to 0.

> Source/WebKit/UIProcess/WebPageProxy.cpp:8213
> +void WebPageProxy::deleteSurrounding(int offset, unsigned characterCount)

Should this be an int64_t, to match the WebPage::deleteSurrounding()?

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:45
> +    unsigned surroundingCursorIndex;

Maybe initialize this too, if needed.

[Carlos Garcia Campos]

Comment on attachment 386674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386674&action=review

>> Source/WebKit/UIProcess/API/gtk/WebKitInputMethodContextImplGtk.cpp:32
>> +    unsigned surroundingCursorIndex;
> 
> Maybe explicitly initialize this to 0.

We don't do explicit initializations in GObject private structs because they are always zero-filled on allocation by GLib.

>> Source/WebKit/UIProcess/WebPageProxy.cpp:8213
>> +void WebPageProxy::deleteSurrounding(int offset, unsigned characterCount)
> 
> Should this be an int64_t, to match the WebPage::deleteSurrounding()?

Yes, I forgot to change this one

>> Tools/TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:45
>> +    unsigned surroundingCursorIndex;
> 
> Maybe initialize this too, if needed.

It's not needed, it's already zero-filled on allocation.

[Carlos Garcia Campos]

Committed r254122: <https://trac.webkit.org/changeset/254122>