Bug 205700

Summary: IndexedDB: use unique_ptr for IDBDatabaseInfo in IDBDatabase
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED INVALID    
Severity: Normal CC: alecflett, beidson, ews-watchlist, jsbell, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sihui Liu
Reported 2020-01-02 15:56:07 PST
<rdar://problem/58146433>
Attachments
Patch (11.69 KB, patch)
2020-01-02 16:00 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2020-01-02 16:00:51 PST
Created attachment 386643 [details] Patch
Maciej Stachowiak
Comment 2 2020-01-02 18:07:41 PST
Comment on attachment 386643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386643&action=review > Source/WebCore/ChangeLog:9 > + IDBDatabase should have its own IDBDatabaseInfo. This could use a better explanation of the change. I also don't understand how using a unique_ptr here instead of inlining the IDBDatabaseInfo would prevent a use-after-free (mentioned in the associated Radar). Looks like it's mechanically correct, but I'm not clear on how it fixes the bug.
Sihui Liu
Comment 3 2020-01-06 14:52:12 PST
(In reply to Maciej Stachowiak from comment #2) > Comment on attachment 386643 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386643&action=review > > > Source/WebCore/ChangeLog:9 > > + IDBDatabase should have its own IDBDatabaseInfo. > > This could use a better explanation of the change. > > I also don't understand how using a unique_ptr here instead of inlining the > IDBDatabaseInfo would prevent a use-after-free (mentioned in the associated > Radar). Looks like it's mechanically correct, but I'm not clear on how it > fixes the bug. Right, this is not the correct fix. I've updated the radar.
Note You need to log in before you can comment on or make changes to this bug.