Bug 205697

Summary: AI rule for PutById can only observe transitions when it watches the condition
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ysuzuki: review+
patch for landing none

Saam Barati
Reported 2020-01-02 15:16:27 PST
otherwise, it has no way to know that the transition it reports is valid at runtime
Attachments
patch (9.60 KB, patch)
2020-01-02 16:05 PST, Saam Barati 		ysuzuki: review+
DetailsFormatted DiffDiff
patch for landing (9.57 KB, patch)
2020-01-02 16:42 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-01-02 15:48:16 PST
<rdar://problem/56814254>
Saam Barati
Comment 2 2020-01-02 16:05:10 PST
Created attachment 386644 [details] patch
Yusuke Suzuki
Comment 3 2020-01-02 16:36:31 PST
Comment on attachment 386644 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=386644&action=review r=me > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:3771 > + bool isOK = true; I recommend using `allGood` instead of `isOK` to align the name to the constant-folding phase one.
Saam Barati
Comment 4 2020-01-02 16:41:09 PST
Comment on attachment 386644 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=386644&action=review >> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:3771 >> + bool isOK = true; > > I recommend using `allGood` instead of `isOK` to align the name to the constant-folding phase one. will do
Saam Barati
Comment 5 2020-01-02 16:42:11 PST
Created attachment 386646 [details] patch for landing
WebKit Commit Bot
Comment 6 2020-01-03 01:20:55 PST
Comment on attachment 386646 [details] patch for landing Clearing flags on attachment: 386646 Committed r253991: <https://trac.webkit.org/changeset/253991>
WebKit Commit Bot
Comment 7 2020-01-03 01:20:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.