Bug 205649

Summary:

REGRESSION(r253896): [GTK][WPE] Broke the build with GCC-7

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

WebKitGTK

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, commit-queue, ews-watchlist, fpizlo, ggaren, keith_miller, mark.lam, msaboff, saam, tzagallo, ysuzuki

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

205232

Attachments:

Description	Flags
Patch	none

Description Carlos Alberto Lopez Perez 2019-12-30 12:12:13 PST

r253896 broke the build in Ubuntu LTS 18.04, which ships with GCC version 7.3.0

The build failure is:

/usr/bin/ld.gold: error: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LowLevelInterpreter.cpp.o: requires dynamic R_X86_64_PC32 reloc against 'slow_path_checkpoint_osr_exit_from_inlined_call' which may overflow at runtime; recompile with -fPIC
collect2: error: ld returned 1 exit status

Complete log: Build log failure: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Ubuntu%20LTS%20%28Build%29/builds/27705

The error is not reproducible with GCC-8, neither with Clang.

Comment 1 Carlos Alberto Lopez Perez 2019-12-30 12:48:54 PST

Created attachment 386543 [details]
Patch

Comment 2 WebKit Commit Bot 2019-12-30 15:53:37 PST

Comment on attachment 386543 [details]
Patch

Clearing flags on attachment: 386543

Committed r253955: <https://trac.webkit.org/changeset/253955>

Comment 3 WebKit Commit Bot 2019-12-30 15:53:39 PST

All reviewed patches have been landed.  Closing bug.