Bug 205614

Summary: Allow disabling internal and experimental features in run-webkit-tests
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, glenn, jbedard, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
thorton: review+
patch none

Antti Koivisto
Reported 2019-12-28 03:14:51 PST
Features that are disabled by default can be enabled using --internal/experimental-feature parameter but there is no way to disable features that are enabled by default.
Attachments
patch (6.22 KB, patch)
2019-12-28 03:35 PST, Antti Koivisto 		thorton: review+
DetailsFormatted DiffDiff
patch (6.21 KB, patch)
2019-12-28 12:57 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-12-28 03:35:50 PST
Created attachment 386465 [details] patch
Tim Horton
Comment 2 2019-12-28 10:00:56 PST
Comment on attachment 386465 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=386465&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:122 > + help="Enable (disable) an internal feature (--internal-feature FeatureEnabled[=true|false])"), s/FeatureEnabled/FeatureName/, I think. I read it wrong the first three times and had to read the changelog to understand.
Antti Koivisto
Comment 3 2019-12-28 12:57:43 PST
Created attachment 386474 [details] patch
WebKit Commit Bot
Comment 4 2019-12-28 13:42:40 PST
Comment on attachment 386474 [details] patch Clearing flags on attachment: 386474 Committed r253927: <https://trac.webkit.org/changeset/253927>
WebKit Commit Bot
Comment 5 2019-12-28 13:42:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-12-28 13:43:23 PST
<rdar://problem/58226988>
Note You need to log in before you can comment on or make changes to this bug.