Bug 205571

Summary: [JSC] Wasm OSR entry should capture top-most enclosing-stack
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch keith_miller: review+

Yusuke Suzuki
Reported 2019-12-23 15:42:34 PST
<rdar://problem/58137399>
Attachments
Patch (9.24 KB, patch)
2019-12-23 16:26 PST, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-12-23 16:26:42 PST
Created attachment 386366 [details] Patch
Keith Miller
Comment 2 2019-12-23 17:08:51 PST
Comment on attachment 386366 [details] Patch r=me
Yusuke Suzuki
Comment 3 2019-12-23 17:11:20 PST
Committed r253895: <https://trac.webkit.org/changeset/253895>
Saam Barati
Comment 4 2019-12-30 12:54:52 PST
Comment on attachment 386366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386366&action=review > Source/JavaScriptCore/ChangeLog:8 > + OSR entry should capture the top-most enclosing-stack too. what is top-most here? The first thing to pop off the stack, or the last?
Yusuke Suzuki
Comment 5 2020-01-02 10:55:50 PST
Comment on attachment 386366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386366&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + OSR entry should capture the top-most enclosing-stack too. > > what is top-most here? The first thing to pop off the stack, or the last? Stack-top ones, the first thing.
Note You need to log in before you can comment on or make changes to this bug.