Bug 205558

Summary: [GTK] Make ondemand hardware acceleration policy never leave AC mode
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cmarcelo, ews-watchlist, gustavo, gyuyoung.kim, luiz, magomez, noam, ryuan.choi, sergio, svillar, zan, zeno
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch svillar: review+

Carlos Garcia Campos
Reported 2019-12-23 07:10:22 PST
We still enter AC mode on demand but we never leave it for the same drawing area. This avoids scrolling performance problems with some websites that start small accelerated animation while scrolling (like WebKit bugzilla review tool), due to constant enter/leave AC mode.
Attachments
Patch (3.15 KB, patch)
2019-12-23 07:16 PST, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-12-23 07:16:08 PST
Created attachment 386342 [details] Patch
EWS Watchlist
Comment 2 2019-12-23 07:16:50 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Sergio Villar Senin
Comment 3 2019-12-23 10:46:34 PST
Comment on attachment 386342 [details] Patch I'm fine with the change. I'd like to hear from Zan or Miguel though, as they might have a different opinion on the matter.
Zan Dobersek
Comment 4 2020-01-01 23:52:18 PST
It makes sense.
Carlos Garcia Campos
Comment 5 2020-01-02 01:05:02 PST
Committed r253974: <https://trac.webkit.org/changeset/253974>
Note You need to log in before you can comment on or make changes to this bug.