Bug 20555

Summary: Move graphs for resources under #resources-container-content
Product: WebKit Reporter: Anthony Ricaud <rik>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 14378    
Attachments:
Description Flags
Work in progress patch
none
Working patch
none
Working better
none
Proposed patch timothy: review+

Anthony Ricaud
Reported 2008-08-27 18:49:27 PDT
In order to make the timeline view adjustable, we need to move every graph for resources. This should not change any behaviour.
Attachments
Work in progress patch (10.74 KB, patch)
2008-08-27 18:54 PDT, Anthony Ricaud 		no flags
DetailsFormatted DiffDiff
Working patch (11.89 KB, patch)
2008-09-12 16:22 PDT, Anthony Ricaud 		no flags
DetailsFormatted DiffDiff
Working better (12.53 KB, patch)
2008-09-12 18:30 PDT, Anthony Ricaud 		no flags
DetailsFormatted DiffDiff
Proposed patch (13.59 KB, patch)
2008-09-14 15:18 PDT, Anthony Ricaud 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Anthony Ricaud
Comment 1 2008-08-27 18:54:18 PDT
Created attachment 23048 [details] Work in progress patch This seems to behave exactly the same. Except one big problem : sorting the graphs like the resources...
Timothy Hatcher
Comment 2 2008-08-27 21:28:33 PDT
Is updateGraphSideWidth needed any more? Can it just be in the CSS now with a 100% width? That would eliminate a loop through all resources when resizing.
Anthony Ricaud
Comment 3 2008-09-12 16:22:23 PDT
Created attachment 23381 [details] Working patch This patch is doing the job. But I have to look for obsolete CSS rules, JS code and better variable names.
Anthony Ricaud
Comment 4 2008-09-12 18:30:13 PDT
Created attachment 23385 [details] Working better Forgot to clean the graphs after a refresh.
Anthony Ricaud
Comment 5 2008-09-14 15:18:59 PDT
Created attachment 23419 [details] Proposed patch Removed a CSS rule, renamed WebInspector.ResourceGraphElement to WebInspector.ResourceGraph and renamed _graphSideElement to _graphElement. Added my copyright too.
Timothy Hatcher
Comment 6 2008-09-14 21:35:29 PDT
Comment on attachment 23419 [details] Proposed patch Nice work!
Timothy Hatcher
Comment 7 2008-09-14 22:38:18 PDT
Landed in r36426.
Note You need to log in before you can comment on or make changes to this bug.