Bug 205520 – ANGLE: Fix WebGL conformance tests for EXT_texture_filter_anisotropic

• Component: ANGLE
• Status: RESOLVED FIXED

[James Darpinian]

ANGLE: Fix WebGL conformance tests for EXT_texture_filter_anisotropic

[James Darpinian]

Created attachment 386256 [details]
ANGLE: Fix WebGL conformance tests for EXT_texture_filter_anisotropic

[James Darpinian]

Created attachment 386283 [details]
Rebaseline layout tests

[James Darpinian]

Created attachment 386423 [details]
Remove obsolete expectations files

[James Darpinian]

Created attachment 386424 [details]
Fix one more expectations file

[James Darpinian]

Layout tests are fixed now, so this should be good to go.

[Darin Adler]

Comment on attachment 386424 [details]
Fix one more expectations file

View in context: https://bugs.webkit.org/attachment.cgi?id=386424&action=review

I’d like to say review+ -- the part of this that corrects types from integer to float seems obviously correct -- but I don’t know enough to be sure this is exactly OK as is.

> Source/WebCore/ChangeLog:3
> +        ANGLE: Fix WebGL conformance tests for EXT_texture_filter_anisotropic

It’s a bit ambiguous or imprecise to title a patch that fixes behavior of the web engine "fix conformance tests". It’s not the tests we are fixing!

> Source/WebCore/ChangeLog:17
> +        * html/canvas/WebGL2RenderingContext.cpp:
> +        (WebCore::WebGL2RenderingContext::getExtension):
> +        (WebCore::WebGL2RenderingContext::getSupportedExtensions):
> +        (WebCore::WebGL2RenderingContext::getParameter):
> +        * html/canvas/WebGLRenderingContext.cpp:
> +        (WebCore::WebGLRenderingContext::getExtension):
> +        * html/canvas/WebGLRenderingContextBase.cpp:
> +        (WebCore::WebGLRenderingContextBase::getTexParameter):

It would be nice to have comments that explain what the changes are.

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:-1372
> -    ENABLE_IF_REQUESTED(EXTTextureFilterAnisotropic, m_extTextureFilterAnisotropic, "WEBKIT_EXT_texture_filter_anisotropic", enableSupportedExtension("GL_OES_texture_float"_s));

What mitigates the risk of removing this? Is this possibly incompatible with WebKit-specific content, such as content embedded in iOS apps, that does not work with other web engines?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:-144
> -    ENABLE_IF_REQUESTED(EXTTextureFilterAnisotropic, m_extTextureFilterAnisotropic, "WEBKIT_EXT_texture_filter_anisotropic", enableSupportedExtension("GL_EXT_texture_filter_anisotropic"_s));

What mitigates the risk of removing this? Is this possibly incompatible with WebKit-specific content, such as content embedded in iOS apps, that does not work with other web engines?

[Dean Jackson]

Comment on attachment 386424 [details]
Fix one more expectations file

View in context: https://bugs.webkit.org/attachment.cgi?id=386424&action=review

>> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:-1372
>> -    ENABLE_IF_REQUESTED(EXTTextureFilterAnisotropic, m_extTextureFilterAnisotropic, "WEBKIT_EXT_texture_filter_anisotropic", enableSupportedExtension("GL_OES_texture_float"_s));
> 
> What mitigates the risk of removing this? Is this possibly incompatible with WebKit-specific content, such as content embedded in iOS apps, that does not work with other web engines?

I think it is safe to remove this. Mozilla hasn't supported their equivalent for a long time (I tried searching in their commits but failed, although I see a warning of imminent removal in 2013). Blink removed this about the same time (again, searching through their history is difficult because of file renames after the fork). A quick search on github shows three.js uses it, but only as a fallback from EXT_texture_filter_anisotropic. The WebGL conformance suite uses it in the same manner (we should remove that too).

This was one of the first ratified extensions, so it would have to be extremely old content, written when Chrome supported this.

[WebKit Commit Bot]

Comment on attachment 386424 [details]
Fix one more expectations file

Clearing flags on attachment: 386424

Committed r253919: <https://trac.webkit.org/changeset/253919>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58215866>