Bug 205519

Summary: Add logging for Modern EME methods.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hta, kondapallykalyan, philipj, sergio, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2019-12-20 14:14:32 PST
Add logging for Modern EME methods.
Attachments
Patch (49.48 KB, patch)
2019-12-20 14:16 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (59.26 KB, patch)
2019-12-20 15:15 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (59.39 KB, patch)
2020-01-06 15:39 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (60.78 KB, patch)
2020-01-07 15:47 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (60.21 KB, patch)
2020-03-10 09:22 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2019-12-20 14:16:24 PST
Created attachment 386252 [details] Patch
Jer Noble
Comment 2 2019-12-20 15:15:53 PST
Created attachment 386264 [details] Patch
Eric Carlson
Comment 3 2019-12-20 15:26:12 PST
Comment on attachment 386264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386264&action=review > Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp:61 > + auto identifier = WTF::Logger::LogSiteIdentifier("MediaKeys", __func__, this); We shouldn't log pointer values. > Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp:97 > + auto identifier = WTF::Logger::LogSiteIdentifier("MediaKeys", __func__, this); Ditto. > Source/WebCore/Modules/encryptedmedia/NavigatorEME.cpp:78 > + auto identifier = WTF::Logger::LogSiteIdentifier("NavigatorEME", __func__, &navigator); Ditto
Jer Noble
Comment 4 2019-12-20 15:40:10 PST
(In reply to Eric Carlson from comment #3) > Comment on attachment 386264 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386264&action=review > > > Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp:61 > > + auto identifier = WTF::Logger::LogSiteIdentifier("MediaKeys", __func__, this); > > We shouldn't log pointer values. I thought that was the whole point of LogSiteIdentifier?
Eric Carlson
Comment 5 2019-12-20 22:47:56 PST
Comment on attachment 386264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386264&action=review >>> Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp:61 >>> + auto identifier = WTF::Logger::LogSiteIdentifier("MediaKeys", __func__, this); >> >> We shouldn't log pointer values. > > I thought that was the whole point of LogSiteIdentifier? The identifier should be a unique, non-pointer, value. Many objects use the uniqueLogIdentifier() function to generate an id.
Jer Noble
Comment 6 2020-01-06 15:39:01 PST
Created attachment 386900 [details] Patch for landing
Jer Noble
Comment 7 2020-01-07 15:47:21 PST
Created attachment 387047 [details] Patch for landing
Jer Noble
Comment 8 2020-03-10 09:22:07 PDT
Created attachment 393156 [details] Patch for landing
WebKit Commit Bot
Comment 9 2020-03-10 11:25:38 PDT
Comment on attachment 393156 [details] Patch for landing Clearing flags on attachment: 393156 Committed r258221: <https://trac.webkit.org/changeset/258221>
WebKit Commit Bot
Comment 10 2020-03-10 11:25:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2020-03-10 11:26:18 PDT
<rdar://problem/60281804>
Note You need to log in before you can comment on or make changes to this bug.