Bug 205466

Summary: Don't cache self customs on dictionaries
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
mark.lam: review+
patch for landing none

Saam Barati
Reported 2019-12-19 12:59:03 PST
Since we cache the constant function pointer (unlike values and getters/setters, which we read dynamically from property storage), we always need to be notified when the property is replaced. For properties/getter/setters, then the property updates, the inline cache still does the right thing.
Attachments
WIP (10.20 KB, patch)
2019-12-19 12:59 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (14.46 KB, patch)
2019-12-19 13:58 PST, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (14.45 KB, patch)
2019-12-19 14:40 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-12-19 12:59:31 PST
<rdar://problem/58075545>
Saam Barati
Comment 2 2019-12-19 12:59:53 PST
Created attachment 386134 [details] WIP test on EWS
Saam Barati
Comment 3 2019-12-19 13:58:19 PST
Created attachment 386141 [details] patch
Mark Lam
Comment 4 2019-12-19 14:24:02 PST
Comment on attachment 386141 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=386141&action=review r=me > Source/JavaScriptCore/ChangeLog:11 > + inline cache won't fail (because we wont transition structures) if that /wont/won't/
Saam Barati
Comment 5 2019-12-19 14:40:19 PST
Created attachment 386145 [details] patch for landing
WebKit Commit Bot
Comment 6 2019-12-19 19:32:45 PST
Comment on attachment 386145 [details] patch for landing Clearing flags on attachment: 386145 Committed r253810: <https://trac.webkit.org/changeset/253810>
WebKit Commit Bot
Comment 7 2019-12-19 19:32:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.