Summary: | DOMPromise::whenPromiseIsSettled is asserting in service worker | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2019-12-19 00:09:41 PST
Created attachment 386080 [details]
Patch
Comment on attachment 386080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386080&action=review > Source/WebCore/ChangeLog:7 > + Can you please explain what your change does and why? (In reply to Chris Dumez from comment #2) > Comment on attachment 386080 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386080&action=review > > > Source/WebCore/ChangeLog:7 > > + > > Can you please explain what your change does and why? OK, will add something like the following to the change log: The promise.get(@then) is sometimes throwing an exception probably due to service worker being stopped. We need to catch the JS exception and exit early if the getter fails. Created attachment 386197 [details]
Patch for landing
Comment on attachment 386197 [details] Patch for landing Clearing flags on attachment: 386197 Committed r253813: <https://trac.webkit.org/changeset/253813> All reviewed patches have been landed. Closing bug. |