Bug 205426

Summary: [GTK] Build fix for ANGLE_WEBGL after r253650
Product: WebKit Reporter: ChangSeok Oh <changseok>
Component: WebKitGTKAssignee: ChangSeok Oh <changseok>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, cgarcia, clopez, commit-queue, dino, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

ChangSeok Oh
Reported 2019-12-18 17:01:20 PST
GTK port build with USE_ANGLE_WEBGL has been broken since r253650 removed libglesv2_entry_points_headers.
Attachments
Patch (1.68 KB, patch)
2019-12-18 17:15 PST, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2019-12-18 17:15:40 PST
Created attachment 386037 [details] Patch
EWS Watchlist
Comment 2 2019-12-18 17:16:33 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
ChangSeok Oh
Comment 3 2019-12-18 17:23:11 PST
Otherwise, we can move the change to PlatformGTK.txt. I am not sure which is better. Please let me know if you have a different idea.
Carlos Alberto Lopez Perez
Comment 4 2019-12-18 17:49:19 PST
Comment on attachment 386037 [details] Patch r=me
ChangSeok Oh
Comment 5 2019-12-19 01:08:45 PST
Comment on attachment 386037 [details] Patch O.K. Let's go with this. Thanks.
WebKit Commit Bot
Comment 6 2019-12-19 01:53:19 PST
Comment on attachment 386037 [details] Patch Clearing flags on attachment: 386037 Committed r253745: <https://trac.webkit.org/changeset/253745>
WebKit Commit Bot
Comment 7 2019-12-19 01:53:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.