Bug 205412

Summary: REGRESSION: [ Mojave Debug wk1 ] webgl/1.0.3/conformance/rendering/many-draw-calls.html is Timing out
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, dino, jlewis3, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=182144
https://bugs.webkit.org/show_bug.cgi?id=205668

Description Truitt Savell 2019-12-18 14:13:34 PST
webgl/1.0.3/conformance/rendering/many-draw-calls.html

This test is timing out often on Mojave Debug wk1

History:
https://results.webkit.org/?suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Frendering%2Fmany-draw-calls.html

History indicates this began timing out around 253292
Comment 1 Radar WebKit Bug Importer 2019-12-18 14:13:57 PST
<rdar://problem/58057313>
Comment 2 Truitt Savell 2019-12-18 14:17:56 PST
Diff showed 

--- /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/webgl/1.0.3/conformance/rendering/many-draw-calls-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/webgl/1.0.3/conformance/rendering/many-draw-calls-actual.txt
@@ -1,5 +1,14 @@
+FAIL: Timed out waiting for notifyDone to be called
 This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
 
 Test: ../../resources/webgl_test_files/conformance/rendering/many-draw-calls.html
-[ PASS ] All tests passed
+[ 1: PASS ] Completed 10 iterations
+[ 2: PASS ] Completed 20 iterations
+[ 3: PASS ] Completed 30 iterations
+[ 4: PASS ] Completed 40 iterations
+[ 5: PASS ] Completed 50 iterations
+[ 6: PASS ] Completed 60 iterations
+[ 7: PASS ] Completed 70 iterations
+[ 8: PASS ] Completed 80 iterations
+[ 9: PASS ] Completed 90 iterations
Comment 3 Truitt Savell 2019-12-18 14:21:51 PST
I was unable to reproduce this on my system at this time.
Comment 4 Truitt Savell 2019-12-19 08:36:37 PST
marked test as timeout while it is investigated in https://trac.webkit.org/changeset/253753/webkit
Comment 5 Alexey Proskuryakov 2019-12-20 10:02:10 PST
This test is already tracked in bug 182144, where it got skipped. Must be re-enabled in a more specific TestExpectation I guess?
Comment 6 Truitt Savell 2019-12-20 10:04:21 PST
It is skipped here:
LayoutTests/platform/ios-wk2/TestExpectations:1234:webkit.org/b/182144 [ Debug ] webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Skip ]
Comment 7 Alexey Proskuryakov 2019-12-31 15:03:23 PST
This test was just getting gradually slower, until it started to time out. Mojave bots still need to be rebooted every couple weeks, could it be that we forgot to?

I just rebooted them all, let's see if that helps. But also, there is an ANGLE regression on the same test, so it will be hard to tell.
Comment 8 Alexey Proskuryakov 2020-01-05 19:12:29 PST
This test passes again after rebooting and reverting ANGLE. So I think that this is just about the OS getting slower with time, and we need to keep rebooting High sierra and Mojave bots periodically.