Bug 205392

Summary: Invalidate only affected elements after media query evaluation changes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, tsavell, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205449, 205540    
Bug Blocks: 204448    
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch
none
patch
none
patch
none
patch
none
patch
none
patch
zalan: review+
gcc build test
none
gcc build test
none
gcc build test
none
gcc build test
none
gcc build test
none
patch
none
patch
none
patch none

Description Antti Koivisto 2019-12-18 06:36:41 PST 
We are currently invalidating the whole tree. Invalidate only the affected parts of the DOM using invalidation rule sets.
Comment 1 Antti Koivisto 2019-12-18 12:22:19 PST 
Created attachment 385993 [details]
patch
Comment 2 Antti Koivisto 2019-12-18 12:57:50 PST 
Created attachment 385997 [details]
patch
Comment 3 Antti Koivisto 2019-12-18 22:59:09 PST 
Created attachment 386072 [details]
patch
Comment 4 Antti Koivisto 2019-12-19 00:37:53 PST 
Created attachment 386079 [details]
patch
Comment 5 Antti Koivisto 2019-12-20 02:07:51 PST 
Created attachment 386189 [details]
patch
Comment 6 Antti Koivisto 2019-12-20 02:20:05 PST 
Created attachment 386190 [details]
patch
Comment 7 Antti Koivisto 2019-12-20 02:21:31 PST 
Created attachment 386191 [details]
patch
Comment 8 Antti Koivisto 2019-12-20 02:25:16 PST 
Created attachment 386192 [details]
patch
Comment 9 Antti Koivisto 2019-12-20 03:18:04 PST 
Created attachment 386194 [details]
patch
Comment 10 Antti Koivisto 2019-12-20 03:50:15 PST 
Created attachment 386198 [details]
gcc build test
Comment 11 Antti Koivisto 2019-12-20 03:58:04 PST 
Created attachment 386199 [details]
gcc build test
Comment 12 Antti Koivisto 2019-12-20 04:45:54 PST 
Created attachment 386203 [details]
gcc build test
Comment 13 Antti Koivisto 2019-12-20 04:59:51 PST 
Created attachment 386204 [details]
gcc build test
Comment 14 Antti Koivisto 2019-12-20 06:30:08 PST 
Created attachment 386212 [details]
gcc build test
Comment 15 Antti Koivisto 2019-12-20 07:06:59 PST 
Created attachment 386216 [details]
patch
Comment 16 WebKit Commit Bot 2019-12-20 08:34:08 PST 
Comment on attachment 386216 [details]
patch

Clearing flags on attachment: 386216

Committed r253820: <https://trac.webkit.org/changeset/253820>
Comment 17 WebKit Commit Bot 2019-12-20 08:34:10 PST 
All reviewed patches have been landed.  Closing bug.
Comment 18 Radar WebKit Bug Importer 2019-12-20 08:35:18 PST 
<rdar://problem/58115301>
Comment 19 Truitt Savell 2019-12-20 13:51:54 PST 
Reverted r253820 for reason:

Broke Mac testing

Committed r253844: <https://trac.webkit.org/changeset/253844>
Comment 20 Antti Koivisto 2019-12-21 04:29:44 PST 
The HashTrait change exposed a bug in the content extension code. I'll do that change separately in bug 205540.
Comment 21 Antti Koivisto 2019-12-21 09:24:44 PST 
Created attachment 386297 [details]
patch
Comment 22 Antti Koivisto 2019-12-22 07:35:57 PST 
Created attachment 386315 [details]
patch
Comment 23 WebKit Commit Bot 2019-12-22 10:07:03 PST 
Comment on attachment 386315 [details]
patch

Clearing flags on attachment: 386315

Committed r253875: <https://trac.webkit.org/changeset/253875>
Comment 24 WebKit Commit Bot 2019-12-22 10:07:05 PST 
All reviewed patches have been landed.  Closing bug.