Bug 205389

Summary: Move FrameLoader::addHTTPOriginIfNeeded into ResourceRequest
Product: WebKit Reporter: Rob Buis <rbuis>
Component: Page LoadingAssignee: Rob Buis <rbuis>
Status: RESOLVED INVALID    
Severity: Normal CC: beidson, cdumez, dbates, ews-watchlist, japhet, youennf
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rob Buis
Reported 2019-12-18 04:32:07 PST
Move FrameLoader::addHTTPOriginIfNeeded into ResourceRequest.
Attachments
Patch (12.52 KB, patch)
2019-12-18 04:34 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2019-12-18 04:34:12 PST
Created attachment 385959 [details] Patch
youenn fablet
Comment 2 2019-12-20 03:13:47 PST
Comment on attachment 385959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385959&action=review > Source/WebCore/loader/FrameLoader.cpp:-3024 > - } This particular code is lost. Can you explain why this is fine to do so?
Rob Buis
Comment 3 2020-03-26 01:19:46 PDT
We already have a different solution now which is more efficient, since the SecurityOrigin does not have to be computed in case we do not need to append the Origin header.
Note You need to log in before you can comment on or make changes to this bug.