Summary: | [CoordinatedGraphics] ThreadedDisplayRefreshMonitor is never released | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, cmarcelo, ews-watchlist, gyuyoung.kim, luiz, noam, ryuan.choi, sergio, zan, zeno | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-12-18 04:15:04 PST
Created attachment 385956 [details]
Patch
Comment on attachment 385956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385956&action=review > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:574 > + changeWindowScreen(); This is problematic, cause the lambda is using m_layerTreeHost which is null. Comment on attachment 385956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385956&action=review >> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:574 >> + changeWindowScreen(); > > This is problematic, cause the lambda is using m_layerTreeHost which is null. This is called right after setting m_layerTreeHost, or does the lambda capture the value at the time it's declared, even when a reference is passed? It's not crashing here, for sure. Created attachment 386083 [details]
Try to fix wincairo build
Committed r253744: <https://trac.webkit.org/changeset/253744> |