Bug 205363

Summary: REGRESSION: [ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html is a flakey failure
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: ScrollingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, justin_fan, rniwa, simon.fraser, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=171935
https://bugs.webkit.org/show_bug.cgi?id=205364
Attachments:
Description Flags
Fixes the test wenson_hsieh: review+

Truitt Savell
Reported 2019-12-17 16:09:52 PST
tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html This test is a flakey failure on Mac WK2 History: https://results.webkit.org/?suite=layout-tests&test=tiled-drawing%2Fscrolling%2Ffast-scroll-select-latched-mainframe.html Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-actual.txt @@ -11,16 +11,17 @@ TEST COMPLETE PASS Select did not receive wheel events. +PASS Select did not receive wheel events. (GraphicsLayer (anchor 0.00 0.00) - (bounds 2008.00 2266.00) + (bounds 2008.00 2523.00) (visible rect 0.00, 70.00 785.00 x 585.00) (coverage rect 0.00, 70.00 785.00 x 585.00) (intersects coverage rect 1) (contentsScale 1.00) (children 1 (GraphicsLayer - (bounds 2008.00 2266.00) + (bounds 2008.00 2523.00) (contentsOpaque 1) (visible rect 0.00, 70.00 785.00 x 585.00) (coverage rect 0.00, 0.00 1570.00 x 1755.00)
Attachments
Fixes the test (2.73 KB, patch)
2019-12-18 18:47 PST, Ryosuke Niwa 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-17 16:10:13 PST
<rdar://problem/58025488>
Truitt Savell
Comment 2 2019-12-17 16:12:47 PST
Modified expectation to include all of Mac in https://trac.webkit.org/changeset/253658/webkit
Truitt Savell
Comment 3 2019-12-17 16:14:54 PST
The diff is now different from the previous report of this inn https://bugs.webkit.org/show_bug.cgi?id=171935
Truitt Savell
Comment 4 2019-12-17 16:18:39 PST
History shows this probably began around r252207
Ryosuke Niwa
Comment 5 2019-12-18 18:45:45 PST
I have a fix for this. This test has the same issue as tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html (bug 205364). ./Tools/Scripts/run-webkit-tests --debug LayoutTests/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html --iterations 1000 --no-show-results --exit-after-n-failures=1 --force runs fine with my fix.
Ryosuke Niwa
Comment 6 2019-12-18 18:47:43 PST
Created attachment 386052 [details] Fixes the test
Ryosuke Niwa
Comment 7 2019-12-18 19:12:56 PST
Committed r253734: <https://trac.webkit.org/changeset/253734>
Note You need to log in before you can comment on or make changes to this bug.