Bug 205339

Summary: [GTK][WPE] OffscreenCanvas worker tests that call drawImage crash in debug builds
Product: WebKit Reporter: Chris Lord <clord>
Component: CanvasAssignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, dino, ggaren, sabouhallawa, sam, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Lord
Reported 2019-12-17 07:59:16 PST
Any test that calls OffscreenCanvasRenderingContext2D.drawImage inside a worker will crash in debug builds for the same reasons as the crashes fixed in bug 203884 (calling copyImage, which calls code that isn't safe to run off the main thread). Again, there's no actual need to go through this code path, so the fix is to just use the shorter path that doesn't involve unnecessarily creating an Image object. Patch almost done.
Attachments
Patch (4.47 KB, patch)
2019-12-17 08:35 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2019-12-17 08:35:35 PST
Created attachment 385893 [details] Patch
WebKit Commit Bot
Comment 2 2019-12-18 01:02:52 PST
Comment on attachment 385893 [details] Patch Clearing flags on attachment: 385893 Committed r253675: <https://trac.webkit.org/changeset/253675>
WebKit Commit Bot
Comment 3 2019-12-18 01:02:54 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-12-18 01:03:18 PST
<rdar://problem/58036434>
Note You need to log in before you can comment on or make changes to this bug.