Bug 205249

Summary: jhbuild fails to configure if gettext 0.20 is installed
Product: WebKit Reporter: Emilio Cobos Álvarez (:emilio) <emilio>
Component: WebKitGTKAssignee: Emilio Cobos Álvarez (:emilio) <emilio>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Emilio Cobos Álvarez (:emilio)
Reported 2019-12-15 05:39:08 PST
Because jhbuild is using gettext 0.19, apparently. Anyhow I have a fix that should work.
Attachments
Patch (1.55 KB, patch)
2019-12-15 05:43 PST, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Patch (1.10 KB, patch)
2019-12-15 06:42 PST, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emilio Cobos Álvarez (:emilio)
Comment 1 2019-12-15 05:43:13 PST
Created attachment 385713 [details] Patch
Michael Catanzaro
Comment 2 2019-12-15 06:17:52 PST
Comment on attachment 385713 [details] Patch Thanks. This works, but a better solution is to just update jhbuild to 3.35.2 or master, which has already fixed this problem. This will also fix the second problem preventing use of jhbuild-wrapper on Fedora 31: the old version is incompatible with python3.
Michael Catanzaro
Comment 3 2019-12-15 06:27:57 PST
Just change: jhbuild_revision = 'b1d2ebdef165435c048c59192a32ba69d4f2c6dd' to, say: jhbuild_revision = '93d37507d0fbf550aa3e96b5d632f3772c0189f0' And make sure that works.
Emilio Cobos Álvarez (:emilio)
Comment 4 2019-12-15 06:42:26 PST
Created attachment 385715 [details] Patch
Emilio Cobos Álvarez (:emilio)
Comment 5 2019-12-15 06:42:55 PST
(In reply to Michael Catanzaro from comment #3) > Just change: > > jhbuild_revision = 'b1d2ebdef165435c048c59192a32ba69d4f2c6dd' > > to, say: > > jhbuild_revision = '93d37507d0fbf550aa3e96b5d632f3772c0189f0' > > And make sure that works. Yup, seems to work, thanks!
WebKit Commit Bot
Comment 6 2019-12-15 10:43:47 PST
Comment on attachment 385715 [details] Patch Clearing flags on attachment: 385715 Committed r253539: <https://trac.webkit.org/changeset/253539>
WebKit Commit Bot
Comment 7 2019-12-15 10:43:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.