Bug 205246

Summary: [LFC][IFC] Fix imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-009.html
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

alan
Reported 2019-12-14 21:48:28 PST
ssia
Attachments
Patch (2.09 KB, patch)
2019-12-14 21:53 PST, alan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-14 21:48:51 PST
<rdar://problem/57944015>
alan
Comment 2 2019-12-14 21:53:29 PST
Created attachment 385709 [details] Patch
Antti Koivisto
Comment 3 2019-12-15 00:07:40 PST
Comment on attachment 385709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385709&action=review > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:286 > + // [ ][ ] : adjacent whitespace content has soft wrap opportunity. > + if (lastUncomittedContent->isText() && downcast<InlineTextItem>(*lastUncomittedContent).isWhitespace()) > + isAtSoftWrapOpportunityBeforeWhitespace = true; break-space might need a new strategy at some point. Creating InlineTextItems for each space is not very efficient at all.
alan
Comment 4 2019-12-15 06:09:46 PST
Committed r253535: <https://trac.webkit.org/changeset/253535>
Note You need to log in before you can comment on or make changes to this bug.