Bug 205240

Summary: [iOS] Deny mach lookup access to "*.viewservice" in the WebContent process
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Per Arne Vollan 2019-12-14 14:15:57 PST
As part of sandbox hardening in the WebContent process, mach lookup access to “*.viewservice” should be removed.
Comment 1 Per Arne Vollan 2019-12-14 14:16:12 PST
rdar://problem/56990598
Comment 2 Per Arne Vollan 2019-12-14 14:20:49 PST
Created attachment 385700 [details]
Patch
Comment 3 Brent Fulgham 2019-12-14 14:30:13 PST
Comment on attachment 385700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385700&action=review

R=me

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-446
> -        (xpc-service-name-regex #"\.viewservice$") ;; <rdar://problem/31252371>

Here we go!
Comment 4 Per Arne Vollan 2019-12-14 14:35:36 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 385700 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385700&action=review
> 
> R=me
> 
> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-446
> > -        (xpc-service-name-regex #"\.viewservice$") ;; <rdar://problem/31252371>
> 
> Here we go!

Thanks for reviewing :)
Comment 5 WebKit Commit Bot 2019-12-14 15:20:52 PST
Comment on attachment 385700 [details]
Patch

Clearing flags on attachment: 385700

Committed r253529: <https://trac.webkit.org/changeset/253529>
Comment 6 WebKit Commit Bot 2019-12-14 15:20:54 PST
All reviewed patches have been landed.  Closing bug.