Bug 205227

Summary:

Add power metric to perf dashboard

Product:

WebKit

Reporter:

Zhifei Fang <zhifei_fang>

Component:

New Bugs

Assignee:

Zhifei Fang <zhifei_fang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, dewei_zhu, ews-watchlist, glenn, jbedard, rniwa, webkit-bug-importer, zhifei_fang

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Zhifei Fang

Reported 2019-12-13 16:31:58 PST

Add power metric to perf dashboard

Attachments
Patch (1.20 KB, patch) 2019-12-13 16:32 PST, Zhifei Fang	no flags	Details Formatted Diff Diff
Patch (1.20 KB, patch) 2019-12-14 19:30 PST, Zhifei Fang	no flags	Details Formatted Diff Diff
Patch (3.00 KB, patch) 2019-12-14 19:40 PST, Zhifei Fang	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Zhifei Fang

Comment 1 2019-12-13 16:32:25 PST

Created attachment 385656 [details] Patch

Ryosuke Niwa

Comment 2 2019-12-13 19:11:28 PST

Comment on attachment 385656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385656&action=review > Websites/perf.webkit.org/public/v3/models/metric.js:23 > + 'Power': 'watt', Why not just W? That's the SI unit. Let's also add this to old code in helper-classes.js and v2/data.js.

Zhifei Fang

Comment 3 2019-12-14 19:30:31 PST

Created attachment 385703 [details] Patch

Zhifei Fang

Comment 4 2019-12-14 19:36:35 PST

Sorry, I will add those to data.js and helper-classes.js

Zhifei Fang

Comment 5 2019-12-14 19:40:34 PST

Created attachment 385705 [details] Patch

WebKit Commit Bot

Comment 6 2019-12-15 14:12:41 PST

Comment on attachment 385705 [details] Patch Clearing flags on attachment: 385705 Committed r253542: <https://trac.webkit.org/changeset/253542>