Bug 205223

Summary: Add release assert for selectedIndex in WebKit::WebPopupMenu::show()
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205177
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2019-12-13 16:05:13 PST 
Add release assert for selectedIndex in WebKit::WebPopupMenu::show().

The WebCore::RenderMenuList::showPopup() derives selectedIndex from the render tree, while WebKit::WebPopupMenu::show() calls WebKit::WebPopupMenu::populateItems() which uses the DOM via WebCore::HTMLSelectElement::listItems() which may call WebCore::HTMLSelectElement::recalcListItems().
Comment 1 Radar WebKit Bug Importer 2019-12-13 16:05:38 PST 
<rdar://problem/57929078>
Comment 2 David Kilzer (:ddkilzer) 2019-12-13 17:02:38 PST 
Created attachment 385662 [details]
Patch v1
Comment 3 WebKit Commit Bot 2019-12-14 05:03:14 PST 
Comment on attachment 385662 [details]
Patch v1

Clearing flags on attachment: 385662

Committed r253523: <https://trac.webkit.org/changeset/253523>
Comment 4 WebKit Commit Bot 2019-12-14 05:03:15 PST 
All reviewed patches have been landed.  Closing bug.