Bug 205221

Summary:

Add NS_UNAVAILABLE tags to prevent alloc inits for _WKResourceLoadStatistics* classes

Product:

WebKit

Reporter:

Kate Cheney <katherine_cheney>

Component:

WebKit Misc.

Assignee:

Kate Cheney <katherine_cheney>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, andersca, commit-queue, darin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Kate Cheney

Reported 2019-12-13 15:27:27 PST

_WKResourceLoadStatistics* classes should only be created via API::ResourceLoadStatistics*::create

Attachments
Patch (2.43 KB, patch) 2019-12-13 15:30 PST, Kate Cheney	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-12-13 15:28:09 PST

<rdar://problem/57927809>

Kate Cheney

Comment 2 2019-12-13 15:30:51 PST

Created attachment 385649 [details] Patch

Darin Adler

Comment 3 2019-12-15 17:15:46 PST

Comment on attachment 385649 [details] Patch This prevents accidental init at compile time if someone has the appropriate SDK headers, but to prevent it at runtime I believe the typical technique is to override init with a method that throws an exception.

Kate Cheney

Comment 4 2019-12-16 08:33:58 PST

(In reply to Darin Adler from comment #3) > Comment on attachment 385649 [details] > Patch > > This prevents accidental init at compile time if someone has the appropriate > SDK headers, but to prevent it at runtime I believe the typical technique is > to override init with a method that throws an exception. Good to know, I will address this in a future patch.

WebKit Commit Bot

Comment 5 2019-12-16 09:11:02 PST

Comment on attachment 385649 [details] Patch Clearing flags on attachment: 385649 Committed r253557: <https://trac.webkit.org/changeset/253557>

WebKit Commit Bot

Comment 6 2019-12-16 09:11:04 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.