Bug 205221

Summary: Add NS_UNAVAILABLE tags to prevent alloc inits for _WKResourceLoadStatistics* classes
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, commit-queue, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Kate Cheney 2019-12-13 15:27:27 PST 
_WKResourceLoadStatistics* classes should only be created via API::ResourceLoadStatistics*::create
Comment 1 Radar WebKit Bug Importer 2019-12-13 15:28:09 PST 
<rdar://problem/57927809>
Comment 2 Kate Cheney 2019-12-13 15:30:51 PST 
Created attachment 385649 [details]
Patch
Comment 3 Darin Adler 2019-12-15 17:15:46 PST 
Comment on attachment 385649 [details]
Patch

This prevents accidental init at compile time if someone has the appropriate SDK headers, but to prevent it at runtime I believe the typical technique is to override init with a method that throws an exception.
Comment 4 Kate Cheney 2019-12-16 08:33:58 PST 
(In reply to Darin Adler from comment #3)
> Comment on attachment 385649 [details]
> Patch
> 
> This prevents accidental init at compile time if someone has the appropriate
> SDK headers, but to prevent it at runtime I believe the typical technique is
> to override init with a method that throws an exception.

Good to know, I will address this in a future patch.
Comment 5 WebKit Commit Bot 2019-12-16 09:11:02 PST 
Comment on attachment 385649 [details]
Patch

Clearing flags on attachment: 385649

Committed r253557: <https://trac.webkit.org/changeset/253557>
Comment 6 WebKit Commit Bot 2019-12-16 09:11:04 PST 
All reviewed patches have been landed.  Closing bug.