Bug 205182

Summary: Structure should have a bloom filter of seen identifiers
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
tzagallo: review+
patch for landing none

Saam Barati
Reported 2019-12-12 14:51:49 PST
To speed up ::get Running perf tests now.
Attachments
WIP (11.86 KB, patch)
2019-12-12 14:52 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (3.42 KB, patch)
2019-12-13 15:42 PST, Saam Barati 		tzagallo: review+
DetailsFormatted DiffDiff
patch for landing (4.00 KB, patch)
2019-12-13 17:00 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-12-12 14:52:14 PST
Created attachment 385552 [details] WIP Will make a patch for review if perf results are good.
Saam Barati
Comment 2 2019-12-13 15:29:58 PST
Seems like 0.5% faster on speedo2
Saam Barati
Comment 3 2019-12-13 15:42:50 PST
Created attachment 385651 [details] patch
Tadeu Zagallo
Comment 4 2019-12-13 15:48:10 PST
Comment on attachment 385651 [details] patch r=me
Yusuke Suzuki
Comment 5 2019-12-13 15:52:49 PST
Comment on attachment 385651 [details] patch r=me too. We do not need to consider about static-hash-table here since we use this filter only when Structure::get is called, which means that static-hash-table thing is already considered in JSObject side. My suggestion is adding this rationale to ChangeLog.
Saam Barati
Comment 6 2019-12-13 17:00:04 PST
Created attachment 385660 [details] patch for landing
WebKit Commit Bot
Comment 7 2019-12-13 18:08:21 PST
Comment on attachment 385660 [details] patch for landing Clearing flags on attachment: 385660 Committed r253517: <https://trac.webkit.org/changeset/253517>
WebKit Commit Bot
Comment 8 2019-12-13 18:08:23 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-12-13 18:09:23 PST
<rdar://problem/57932091>
Note You need to log in before you can comment on or make changes to this bug.