Bug 205126

Summary: IndexedDB: Fix a wrong condition in MemoryIDBBackingStore::deleteIndex
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: alecflett, beidson, ews-watchlist, jsbell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch youennf: review+

Sihui Liu
Reported 2019-12-11 10:50:34 PST
...
Attachments
Patch (1.56 KB, patch)
2019-12-11 10:54 PST, Sihui Liu 		youennf: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-12-11 10:54:16 PST
Created attachment 385411 [details] Patch
youenn fablet
Comment 2 2019-12-12 00:20:02 PST
Comment on attachment 385411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385411&action=review > Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:273 > objectStoreInfo->deleteIndex(indexIdentifier); Is there a way to test this? MemoryObjectStore::deleteIndex has some error cases but it seems we ASSERT/return early for some of these cases here.
Sihui Liu
Comment 3 2019-12-12 13:45:35 PST
(In reply to youenn fablet from comment #2) > Comment on attachment 385411 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385411&action=review > > > Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:273 > > objectStoreInfo->deleteIndex(indexIdentifier); > > Is there a way to test this? MemoryObjectStore::deleteIndex has some error > cases but it seems we ASSERT/return early for some of these cases here. Yes, I don't think there is an easy way to test...
Sihui Liu
Comment 4 2019-12-12 13:46:59 PST
It looks like I've somehow included the fix in <https://trac.webkit.org/changeset/253393>... So I would just close this bug.
Radar WebKit Bug Importer
Comment 5 2019-12-12 13:47:24 PST
<rdar://problem/57890405>
Note You need to log in before you can comment on or make changes to this bug.