Bug 205124

Summary: Add test for osr exiting with interpreter on the stack
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Keith Miller 2019-12-11 10:32:08 PST 
Add test for osr exiting with interpreter on the stack
Comment 1 Keith Miller 2019-12-11 10:32:59 PST 
Created attachment 385406 [details]
Patch
Comment 2 Mark Lam 2019-12-11 10:45:10 PST 
Comment on attachment 385406 [details]
Patch

rs=me.  Make sure EWS bots are happy.
Comment 3 Mark Lam 2019-12-11 11:08:17 PST 
Comment on attachment 385406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385406&action=review

> JSTests/stress/osr-exit-with-interpreter-on-stack.js:1
> +//@ requiredOptions('--thresholdForJITAfterWarmUp=10', '--useConcurrentJIT=0')

/requiredOptions/requireOptions/

nit: use '--useConcurrentJIT=false' instead.  I've been told in the past that though the bool option is able to take an int, using it in official code is a no-no.  So, let's just avoid that.
Comment 4 Mark Lam 2019-12-11 11:23:29 PST 
<rdar://problem/55917224>
Comment 5 Keith Miller 2019-12-11 11:31:21 PST 
Created attachment 385416 [details]
Patch for landing
Comment 6 Keith Miller 2019-12-11 11:32:24 PST 
Comment on attachment 385406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385406&action=review

>> JSTests/stress/osr-exit-with-interpreter-on-stack.js:1
>> +//@ requiredOptions('--thresholdForJITAfterWarmUp=10', '--useConcurrentJIT=0')
> 
> /requiredOptions/requireOptions/
> 
> nit: use '--useConcurrentJIT=false' instead.  I've been told in the past that though the bool option is able to take an int, using it in official code is a no-no.  So, let's just avoid that.

Whoops, fixed.

Ehh, we use 0/1 more than true/false currently so I'm gonna stick with 0.
Comment 7 WebKit Commit Bot 2019-12-11 12:15:33 PST 
Comment on attachment 385416 [details]
Patch for landing

Clearing flags on attachment: 385416

Committed r253384: <https://trac.webkit.org/changeset/253384>
Comment 8 WebKit Commit Bot 2019-12-11 12:15:34 PST 
All reviewed patches have been landed.  Closing bug.