Bug 205124

Summary: Add test for osr exiting with interpreter on the stack
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Keith Miller
Reported 2019-12-11 10:32:08 PST
Add test for osr exiting with interpreter on the stack
Attachments
Patch (1.51 KB, patch)
2019-12-11 10:32 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.51 KB, patch)
2019-12-11 11:31 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-12-11 10:32:59 PST
Created attachment 385406 [details] Patch
Mark Lam
Comment 2 2019-12-11 10:45:10 PST
Comment on attachment 385406 [details] Patch rs=me. Make sure EWS bots are happy.
Mark Lam
Comment 3 2019-12-11 11:08:17 PST
Comment on attachment 385406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385406&action=review > JSTests/stress/osr-exit-with-interpreter-on-stack.js:1 > +//@ requiredOptions('--thresholdForJITAfterWarmUp=10', '--useConcurrentJIT=0') /requiredOptions/requireOptions/ nit: use '--useConcurrentJIT=false' instead. I've been told in the past that though the bool option is able to take an int, using it in official code is a no-no. So, let's just avoid that.
Mark Lam
Comment 4 2019-12-11 11:23:29 PST
<rdar://problem/55917224>
Keith Miller
Comment 5 2019-12-11 11:31:21 PST
Created attachment 385416 [details] Patch for landing
Keith Miller
Comment 6 2019-12-11 11:32:24 PST
Comment on attachment 385406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385406&action=review >> JSTests/stress/osr-exit-with-interpreter-on-stack.js:1 >> +//@ requiredOptions('--thresholdForJITAfterWarmUp=10', '--useConcurrentJIT=0') > > /requiredOptions/requireOptions/ > > nit: use '--useConcurrentJIT=false' instead. I've been told in the past that though the bool option is able to take an int, using it in official code is a no-no. So, let's just avoid that. Whoops, fixed. Ehh, we use 0/1 more than true/false currently so I'm gonna stick with 0.
WebKit Commit Bot
Comment 7 2019-12-11 12:15:33 PST
Comment on attachment 385416 [details] Patch for landing Clearing flags on attachment: 385416 Committed r253384: <https://trac.webkit.org/changeset/253384>
WebKit Commit Bot
Comment 8 2019-12-11 12:15:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.