Bug 205119

Summary: Remove certain headers when a redirect causes a request method change
Product: WebKit Reporter: Anne van Kesteren <annevk>
Component: DOMAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, ews-watchlist, japhet, rbuis, rwlbuis, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Anne van Kesteren
Reported 2019-12-11 08:46:55 PST
See https://github.com/whatwg/fetch/pull/977 for the change to Fetch and https://github.com/web-platform-tests/wpt/pull/20596 for tests.
Attachments
Patch (4.24 KB, patch)
2020-05-15 10:48 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (40.80 KB, patch)
2020-05-15 13:26 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (42.00 KB, patch)
2020-05-16 10:06 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (54.59 KB, patch)
2020-05-16 11:48 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (60.35 KB, patch)
2020-05-16 13:35 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (60.12 KB, patch)
2020-05-16 14:11 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (60.35 KB, patch)
2020-05-16 14:51 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (63.50 KB, patch)
2020-05-18 00:15 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (60.33 KB, patch)
2020-05-18 02:37 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (60.33 KB, patch)
2020-05-18 04:54 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (63.32 KB, patch)
2020-05-18 05:45 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (63.27 KB, patch)
2020-05-18 09:01 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.
Anne van Kesteren
Comment 1 2020-04-21 23:33:20 PDT
https://github.com/web-platform-tests/wpt/pull/23164 has more tests.
Rob Buis
Comment 2 2020-05-15 10:48:22 PDT
Created attachment 399493 [details] Patch
Rob Buis
Comment 3 2020-05-15 13:26:14 PDT
Created attachment 399505 [details] Patch
Rob Buis
Comment 4 2020-05-16 10:06:44 PDT
Created attachment 399558 [details] Patch
Rob Buis
Comment 5 2020-05-16 11:48:15 PDT
Created attachment 399561 [details] Patch
Rob Buis
Comment 6 2020-05-16 13:35:50 PDT
Created attachment 399562 [details] Patch
Rob Buis
Comment 7 2020-05-16 14:11:45 PDT
Created attachment 399565 [details] Patch
Rob Buis
Comment 8 2020-05-16 14:51:00 PDT
Created attachment 399570 [details] Patch
Rob Buis
Comment 9 2020-05-18 00:15:00 PDT
Created attachment 399626 [details] Patch
Rob Buis
Comment 10 2020-05-18 02:37:35 PDT
Created attachment 399636 [details] Patch
Rob Buis
Comment 11 2020-05-18 04:54:30 PDT
Created attachment 399637 [details] Patch
Rob Buis
Comment 12 2020-05-18 05:45:46 PDT
Created attachment 399641 [details] Patch
youenn fablet
Comment 13 2020-05-18 07:26:26 PDT
Comment on attachment 399641 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399641&action=review > Source/WebCore/platform/network/ResourceRequestBase.cpp:140 > +void ResourceRequestBase::redirectAsGETIfNeeded(ResourceRequest &newRequest, const ResourceResponse& redirectResponse) const Let's change this method so that newRequest iss 'this' and the redirectRequest is passed as const ResourceRequest&. And then we could write it as: if (!shouldUseGet(redirectRequest, redirectResponse)) return; setHTTPMethod(...) ...
Rob Buis
Comment 14 2020-05-18 09:01:47 PDT
Created attachment 399648 [details] Patch
EWS
Comment 15 2020-05-18 10:53:02 PDT
Committed r261821: <https://trac.webkit.org/changeset/261821> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399648 [details].
Radar WebKit Bug Importer
Comment 16 2020-05-18 10:54:18 PDT
<rdar://problem/63349291>
Note You need to log in before you can comment on or make changes to this bug.