Bug 205114

Summary: [LFC][Integration] Paint seemingly blank runs (0 width, result of negative letter-spacing)
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch koivisto: review+

zalan
Reported 2019-12-11 07:42:19 PST
negative letter-spacing can produce 0 width runs.
Attachments
Patch (3.77 KB, patch)
2019-12-11 07:46 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (2.25 KB, patch)
2019-12-12 13:22 PST, zalan 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-11 07:42:50 PST
<rdar://problem/57837165>
zalan
Comment 2 2019-12-11 07:46:49 PST
Created attachment 385391 [details] Patch
Antti Koivisto
Comment 3 2019-12-11 08:03:56 PST
Comment on attachment 385391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385391&action=review > Source/WebCore/layout/displaytree/DisplayInlineContent.cpp:40 > + if (runRect.intersects(rect) || (runRect.isEmpty() && rect.contains(runRect))) { Empty case can still have width or height. Is it correct to require the entire width or height be contained in rect? Maybe you could add FloatRect::intersectsEvenIfEmpty? There is already uniteEvenIfEmpty.
zalan
Comment 4 2019-12-12 13:22:06 PST
Created attachment 385540 [details] Patch
zalan
Comment 5 2019-12-12 13:32:07 PST
Committed r253442: <https://trac.webkit.org/changeset/253442>
Note You need to log in before you can comment on or make changes to this bug.