Summary: | [WebAuthn] Implement dummy _WKWebAuthenticationPanel SPIs for CTAP PIN support | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||
Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, commit-queue, jiewen_tan, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 181943 | ||||||
Attachments: |
|
Description
Jiewen Tan
2019-12-10 21:45:01 PST
Created attachment 385348 [details]
Patch
Comment on attachment 385348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385348&action=review I think this looks good. Did you run it by Garrett? R=me > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:71 > +- (void)panel:(_WKWebAuthenticationPanel *)panel requestPINWithRetries:(NSUInteger)retries completionHandler:(void (^)(NSData *))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); Do you need a stub implementation to build cleanly? Comment on attachment 385348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385348&action=review Thanks Brent for r+ the patch. >> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:71 >> +- (void)panel:(_WKWebAuthenticationPanel *)panel requestPINWithRetries:(NSUInteger)retries completionHandler:(void (^)(NSData *))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > > Do you need a stub implementation to build cleanly? No, I don't think so given this is a protocol. (In reply to Brent Fulgham from comment #3) > Comment on attachment 385348 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385348&action=review > > I think this looks good. Did you run it by Garrett? R=me Yes, I do. > > > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:71 > > +- (void)panel:(_WKWebAuthenticationPanel *)panel requestPINWithRetries:(NSUInteger)retries completionHandler:(void (^)(NSData *))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > > Do you need a stub implementation to build cleanly? Comment on attachment 385348 [details] Patch Clearing flags on attachment: 385348 Committed r253366: <https://trac.webkit.org/changeset/253366> All reviewed patches have been landed. Closing bug. Committed r253382: <https://trac.webkit.org/changeset/253382> Yet another nit: Committed r253401: <https://trac.webkit.org/changeset/253401> |