Bug 205100

Summary: [WebAuthn] Implement dummy _WKWebAuthenticationPanel SPIs for CTAP PIN support
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch none

Jiewen Tan
Reported 2019-12-10 21:45:01 PST
Implement dummy _WKWebAuthenticationPanel SPIs for CTAP PIN support.
Attachments
Patch (4.66 KB, patch)
2019-12-10 22:01 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-10 21:46:11 PST
<rdar://problem/57822953>
Jiewen Tan
Comment 2 2019-12-10 22:01:36 PST
Created attachment 385348 [details] Patch
Brent Fulgham
Comment 3 2019-12-10 22:25:31 PST
Comment on attachment 385348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385348&action=review I think this looks good. Did you run it by Garrett? R=me > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:71 > +- (void)panel:(_WKWebAuthenticationPanel *)panel requestPINWithRetries:(NSUInteger)retries completionHandler:(void (^)(NSData *))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); Do you need a stub implementation to build cleanly?
Jiewen Tan
Comment 4 2019-12-11 02:23:56 PST
Comment on attachment 385348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385348&action=review Thanks Brent for r+ the patch. >> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:71 >> +- (void)panel:(_WKWebAuthenticationPanel *)panel requestPINWithRetries:(NSUInteger)retries completionHandler:(void (^)(NSData *))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > > Do you need a stub implementation to build cleanly? No, I don't think so given this is a protocol.
Jiewen Tan
Comment 5 2019-12-11 02:24:20 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 385348 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385348&action=review > > I think this looks good. Did you run it by Garrett? R=me Yes, I do. > > > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:71 > > +- (void)panel:(_WKWebAuthenticationPanel *)panel requestPINWithRetries:(NSUInteger)retries completionHandler:(void (^)(NSData *))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > > Do you need a stub implementation to build cleanly?
WebKit Commit Bot
Comment 6 2019-12-11 03:07:53 PST
Comment on attachment 385348 [details] Patch Clearing flags on attachment: 385348 Committed r253366: <https://trac.webkit.org/changeset/253366>
WebKit Commit Bot
Comment 7 2019-12-11 03:07:54 PST
All reviewed patches have been landed. Closing bug.
Jiewen Tan
Comment 8 2019-12-11 11:31:40 PST
Committed r253382: <https://trac.webkit.org/changeset/253382>
Jiewen Tan
Comment 9 2019-12-11 16:18:06 PST
Yet another nit: Committed r253401: <https://trac.webkit.org/changeset/253401>
Note You need to log in before you can comment on or make changes to this bug.