Summary: | Regression(r253277) ASSERTION FAILED: !parameters.request.httpBody() in NetworkConnectionToWebProcess::preconnectTo() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, commit-queue, ggaren, koivisto, tsavell, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 204992 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2019-12-09 15:54:21 PST
Created attachment 385196 [details]
Patch
Comment on attachment 385196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385196&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1539 > + WebProcess::singleton().webLoaderStrategy().preconnectTo(ResourceRequest { loadParameters.request.url() }, *this, *m_mainFrame, StoredCredentialsPolicy::Use, [](const ResourceError&) { }); It would be nicer to construct the request separately with an informative name (urlOnlyRequest?) since this is bit non-obvious. Also didn't you remove the need to give empty lambdas to preconnectTo? Created attachment 385260 [details]
Patch
(In reply to Antti Koivisto from comment #2) > Comment on attachment 385196 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385196&action=review > > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1539 > > + WebProcess::singleton().webLoaderStrategy().preconnectTo(ResourceRequest { loadParameters.request.url() }, *this, *m_mainFrame, StoredCredentialsPolicy::Use, [](const ResourceError&) { }); > > It would be nicer to construct the request separately with an informative > name (urlOnlyRequest?) since this is bit non-obvious. OK. > > Also didn't you remove the need to give empty lambdas to preconnectTo? Oh, looks like I forgot to land that patch :) Created attachment 385263 [details]
Patch
Comment on attachment 385263 [details] Patch Clearing flags on attachment: 385263 Committed r253327: <https://trac.webkit.org/changeset/253327> All reviewed patches have been landed. Closing bug. |