Bug 204995

Summary: [LFC][IFC] Switch over to float based types in inline layout
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2019-12-08 06:37:26 PST
see bug 204986
Attachments
Patch (16.55 KB, patch)
2019-12-08 06:45 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (16.58 KB, patch)
2019-12-08 06:59 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-08 06:42:10 PST
<rdar://problem/57733349>
alan
Comment 2 2019-12-08 06:45:46 PST
Created attachment 385118 [details] Patch
Antti Koivisto
Comment 3 2019-12-08 06:48:44 PST
Comment on attachment 385118 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385118&action=review > Source/WebCore/layout/LayoutUnits.h:37 > +#define USE_FLOAT_AS_BASE_TYPE 1 USE_FLOAT_AS_INLINE_LAYOUT_UNIT or similar?
alan
Comment 4 2019-12-08 06:49:39 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 385118 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385118&action=review > > > Source/WebCore/layout/LayoutUnits.h:37 > > +#define USE_FLOAT_AS_BASE_TYPE 1 > > USE_FLOAT_AS_INLINE_LAYOUT_UNIT or similar? so much better
alan
Comment 5 2019-12-08 06:59:45 PST
Created attachment 385119 [details] Patch
alan
Comment 6 2019-12-08 07:10:13 PST
Committed r253269: <https://trac.webkit.org/changeset/253269>
Note You need to log in before you can comment on or make changes to this bug.