Bug 204987

Summary: Remove invalid assertion in FTL's allocateJSArray().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Mark Lam
Reported 2019-12-07 09:32:29 PST
The assertion (in the compiler thread) does not take into account that the mutator may be in the process of transiting to HavingABadTime. As a result, the assertion may fail intermittently. The assertion is just bad and should be removed. <rdar://problem/57280725>
Attachments
proposed patch. (1.99 KB, patch)
2019-12-07 09:36 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-12-07 09:36:52 PST
Created attachment 385101 [details] proposed patch.
WebKit Commit Bot
Comment 2 2019-12-07 12:16:17 PST
Comment on attachment 385101 [details] proposed patch. Clearing flags on attachment: 385101 Committed r253260: <https://trac.webkit.org/changeset/253260>
WebKit Commit Bot
Comment 3 2019-12-07 12:16:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.