Bug 204986

Summary:

[LFC][IFC] Introduce InlineLayoutUnit

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2019-12-07 07:48:26 PST

While IFC uses LayoutUnit only, CLL has a mixture of different types like float, int and LayoutUnit. In order to match CLL's output, IFC needs to use similar types (or at least types with similar precision). Using LayoutUnit exclusively (and by that lowering the precision compared to what CLL ends up having) could cause significant difference in the final inline layout.
Let's introduce these 2 new types and map them to float, FloatRect 
1. to be able to match CLL's output
2. ensure that we use one type and one type only for geometry computation (can't really force it though).
3. be able to swap out the mapped type to something else when needed (like when we move over to a higher precision LayoutUnit)

Comment 1 Radar WebKit Bug Importer 2019-12-07 08:42:31 PST

<rdar://problem/57728333>

Comment 2 Radar WebKit Bug Importer 2019-12-07 08:51:41 PST

<rdar://problem/57728377>

Comment 3 zalan 2019-12-07 09:23:17 PST

Created attachment 385100 [details]
Patch

Comment 4 WebKit Commit Bot 2019-12-07 10:18:24 PST

Comment on attachment 385100 [details]
Patch

Clearing flags on attachment: 385100

Committed r253255: <https://trac.webkit.org/changeset/253255>

Comment 5 WebKit Commit Bot 2019-12-07 10:18:26 PST

All reviewed patches have been landed.  Closing bug.