Bug 204980
| Summary: | Change adoptNode() for a DocumentFragment with host | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, rniwa, twilco.o, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=246899 | ||
| Bug Depends on: | |||
| Bug Blocks: | 148695 | ||
Anne van Kesteren
See https://github.com/whatwg/dom/pull/754 and https://github.com/web-platform-tests/wpt/pull/16348. In particular, you'll need to return early from adoptNode() if the DocumentFragment has a host (and is not a shadow root).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/57730074>
Anne van Kesteren
Unfortunately the initial fix was not quite correct. There's a new fix up at https://github.com/whatwg/dom/pull/819 that I'd appreciate review on.
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/2034
EWS
Committed 252098@main (ab3c0b8cf2a4): <https://commits.webkit.org/252098@main>
Reviewed commits have been landed. Closing PR #2034 and removing active labels.