Summary: | Python 3: Add support in webkitpy.test | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, cdumez, commit-queue, ews-watchlist, glenn, rniwa, slewis, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=184986 | ||||||
Attachments: |
|
Description
Jonathan Bedard
2019-12-06 11:13:08 PST
Created attachment 385029 [details]
Patch
Comment on attachment 385029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385029&action=review > Source/WebKit/Scripts/webkit/messages_unittest.py:31 > + from StringIO import StringIO Why not use Unicode compact function here? Comment on attachment 385029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385029&action=review >> Source/WebKit/Scripts/webkit/messages_unittest.py:31 >> + from StringIO import StringIO > > Why not use Unicode compact function here? Because this file has no webkitpy dependencies, we don't want to introduce one. Comment on attachment 385029 [details] Patch Clearing flags on attachment: 385029 Committed r253219: <https://trac.webkit.org/changeset/253219> All reviewed patches have been landed. Closing bug. |