Bug 204941

Summary: [LFC][Integration] Support isLineBreak() in iterator
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
zalan: review+
patch none

Antti Koivisto
Reported 2019-12-06 03:17:54 PST
Wire it up.
Attachments
patch (2.54 KB, patch)
2019-12-06 03:31 PST, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (2.57 KB, patch)
2019-12-06 05:50 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-12-06 03:31:18 PST
Created attachment 384999 [details] patch
alan
Comment 2 2019-12-06 05:10:53 PST
Comment on attachment 384999 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=384999&action=review > Source/WebCore/layout/displaytree/DisplayRun.h:101 > + bool isLineBreak() const { return layoutBox().isLineBreakBox() || (textContext() && textContext()->content() == "\n"); } && style().preserveNewline() We might need to start tracking type information in DisplayRuns.
Antti Koivisto
Comment 3 2019-12-06 05:50:23 PST
Created attachment 385007 [details] patch
WebKit Commit Bot
Comment 4 2019-12-06 06:34:30 PST
Comment on attachment 385007 [details] patch Clearing flags on attachment: 385007 Committed r253204: <https://trac.webkit.org/changeset/253204>
WebKit Commit Bot
Comment 5 2019-12-06 06:34:31 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-12-06 06:35:19 PST
<rdar://problem/57697294>
Note You need to log in before you can comment on or make changes to this bug.