Bug 204925

Summary: Custom analysis task page should allow schedule any triggerable accepted tests.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: dewei_zhu
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rniwa: review+

dewei_zhu
Reported 2019-12-05 15:30:51 PST
Custom analysis task page should allow schedule any triggerable accepted tests.
Attachments
Patch (1.98 KB, patch)
2019-12-05 15:35 PST, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2019-12-06 13:53 PST, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2019-12-05 15:35:35 PST
Created attachment 384968 [details] Patch
Ryosuke Niwa
Comment 2 2019-12-06 01:19:18 PST
Comment on attachment 384968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384968&action=review > Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js:227 > + const tests = [...acceptedTests].sort((testA, testB) => testA.fullName() > testB.fullName()) ; Nit: a whitespace between ) and ;. This isn't how sorting works in JavaScript. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort
dewei_zhu
Comment 3 2019-12-06 13:53:50 PST
Created attachment 385039 [details] Patch
dewei_zhu
Comment 4 2019-12-06 14:22:34 PST
Comment on attachment 385039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385039&action=review > Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js:231 > + }) ; Forgot to fix the extra space. Will fix it in the final landing patch.
dewei_zhu
Comment 5 2019-12-06 18:21:48 PST
Landed in r253220.
dewei_zhu
Comment 6 2019-12-06 18:22:14 PST
rdar://problem/57436598
Note You need to log in before you can comment on or make changes to this bug.