Bug 204918 – Implementation of additional attribute caching in the IsolatedTree.

• Component: Accessibility
• Status: RESOLVED FIXED

[Andres Gonzalez]

Implementation of additional attribute caching in the IsolatedTree.

[Andres Gonzalez]

Created attachment 384963 [details]
Patch

[chris fleizach]

Looks like some real GTK failures

../../Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceAction.cpp:86:119: error: ‘class WTF::String’ has no member named ‘string’; did you mean ‘String’?
     return webkitAccessibleCacheAndReturnAtkProperty(accessible, AtkCachedActionKeyBinding, core(action)->accessKey().string().utf8());
                                                                                                                       ^~~~~~
                                                                                                                       String

../../Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp: In function ‘const gchar* webkitAccessibleHyperlinkActionGetKeybinding(AtkAction*, gint)’:
../../Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp:101:74: error: ‘class WTF::String’ has no member named ‘string’; did you mean ‘String’?
     accessibleHyperlink->priv->actionKeyBinding = coreObject.accessKey().string().utf8();
                                                                          ^~~~~~
                                                                          String

[Radar WebKit Bug Importer]

<rdar://problem/57682455>

[Andres Gonzalez]

Created attachment 384985 [details]
Patch

[Andres Gonzalez]

Fix for GTK build: AXCoreObject::accessKey() was returning an AtomString and now returns a String, so no need to call AtomString::string().

[chris fleizach]

Comment on attachment 384985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384985&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h:641
> +    bool isMediaControlLabel() const override { return boolAttributeValue(AXPropertyName::IsMediaControlLabel); }

is isMediaControlLabel() this one in the wrong group? or is it implemented unnecessarily?

[Andres Gonzalez]

Created attachment 385010 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #6)
> Comment on attachment 384985 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384985&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h:641
> > +    bool isMediaControlLabel() const override { return boolAttributeValue(AXPropertyName::IsMediaControlLabel); }
> 
> is isMediaControlLabel() this one in the wrong group? or is it implemented
> unnecessarily?

I removed isMediaControlLabel from AXCoreObject since it is not used outside the AXObject class hierarchy. The same applies to all methods that need no implementation in AXIsolatedObject. But we can do this progressively as we go through all the methods. The goal would be that AXCoreObject contains only the methods that are used by client code, and it is a subset of AXObject and AXIsolatedObject.

[WebKit Commit Bot]

Comment on attachment 385010 [details]
Patch

Clearing flags on attachment: 385010

Committed r253261: <https://trac.webkit.org/changeset/253261>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.