Bug 204914

Summary: Improve update-angle.sh and add gni-to-cmake.py
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, dino, ews-watchlist, graouts, gyuyoung.kim, Hironori.Fujii, kbr, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198948    
Attachments:
Description Flags
Improve update-angle.sh and add gni-to-cmake.py
none
Speculative fix for CMake builds
none
Fix CMake build none

James Darpinian
Reported 2019-12-05 14:07:04 PST
Improve update-angle.sh and add gni-to-cmake.py
Attachments
Improve update-angle.sh and add gni-to-cmake.py (134.53 KB, patch)
2019-12-05 14:16 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Speculative fix for CMake builds (134.67 KB, patch)
2019-12-05 14:29 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Fix CMake build (134.72 KB, patch)
2019-12-13 16:00 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2019-12-05 14:16:33 PST
Created attachment 384948 [details] Improve update-angle.sh and add gni-to-cmake.py
EWS Watchlist
Comment 2 2019-12-05 14:17:18 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
James Darpinian
Comment 3 2019-12-05 14:29:57 PST
Created attachment 384951 [details] Speculative fix for CMake builds
James Darpinian
Comment 4 2019-12-13 16:00:20 PST
Created attachment 385652 [details] Fix CMake build
WebKit Commit Bot
Comment 5 2019-12-17 15:02:27 PST
Comment on attachment 385652 [details] Fix CMake build Clearing flags on attachment: 385652 Committed r253650: <https://trac.webkit.org/changeset/253650>
WebKit Commit Bot
Comment 6 2019-12-17 15:02:29 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-12-17 15:03:28 PST
<rdar://problem/58023118>
Fujii Hironori
Comment 8 2019-12-17 20:20:29 PST
Committed r253671: <https://trac.webkit.org/changeset/253671>
Note You need to log in before you can comment on or make changes to this bug.