Bug 204905 – [LFC][IFC] Introduce InlineSoftLineBreakItem

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

to represent preserved segment breaks.

[Radar WebKit Bug Importer]

<rdar://problem/57672472>

[zalan]

Created attachment 384935 [details]
Patch

[Antti Koivisto]

Comment on attachment 384935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384935&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:537
> +    m_inlineItemRuns.append({ softLineBreakItem, contentLogicalWidth(), { }, Display::Run::TextContext { softLineBreakItem.position(), 0, emptyString() } });

Lineboxes include '\n' character contained in the underlying string. Not sure if/where that matters.

> Source/WebCore/layout/inlineformatting/InlineSoftLineBreakItem.h:35
> +class InlineSoftLineBreakItem : public InlineItem {

Feels like this could be combined into one LineBreak class with hard and soft type.

[zalan]

Committed r253170: <https://trac.webkit.org/changeset/253170>

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 384935 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384935&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:537
> > +    m_inlineItemRuns.append({ softLineBreakItem, contentLogicalWidth(), { }, Display::Run::TextContext { softLineBreakItem.position(), 0, emptyString() } });
> 
> Lineboxes include '\n' character contained in the underlying string. Not
> sure if/where that matters.
yeah, good point. fixed.
> 
> > Source/WebCore/layout/inlineformatting/InlineSoftLineBreakItem.h:35
> > +class InlineSoftLineBreakItem : public InlineItem {
> 
> Feels like this could be combined into one LineBreak class with hard and
> soft type.
Hard line break does not have a position because it is not part of a text content. As you mentioned it could have an optional m_position but that's exactly what InlineItem is.