Bug 20490

Summary:

[XBL] XBLBinding should be split into several classes

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

hyatt

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Add 2 new classes and distribute XBLBinding content among them	none
Better changes: uses the boundDocument instead of the boundElement, restore some code changed by mistake	hyatt: review+

Julien Chaffraix

Reported 2008-08-22 19:38:56 PDT

Currently XBLBinding contains all sort of attributes and methods that should be distributed into dedicated classes so that we can share some objects between bindings. Patch forthcoming.

Attachments
Add 2 new classes and distribute XBLBinding content among them (37.86 KB, patch) 2008-08-22 20:20 PDT, Julien Chaffraix	no flags	Details Formatted Diff Diff
Better changes: uses the boundDocument instead of the boundElement, restore some code changed by mistake (37.95 KB, patch) 2008-08-25 04:39 PDT, Julien Chaffraix	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Julien Chaffraix

Comment 1 2008-08-22 20:20:37 PDT

Created attachment 22949 [details] Add 2 new classes and distribute XBLBinding content among them

Julien Chaffraix

Comment 2 2008-08-25 04:39:54 PDT

Created attachment 22978 [details] Better changes: uses the boundDocument instead of the boundElement, restore some code changed by mistake

Eric Seidel (no email)

Comment 3 2008-08-28 13:27:31 PDT

I've been slow, but I'll look at this patch later today.

Sam Weinig

Comment 4 2008-08-31 19:18:29 PDT

Is prototype a name that the spec uses. If not, I would prefer we used another name as to not conflate the term with its usage in JS.

Julien Chaffraix

Comment 5 2008-09-11 03:26:44 PDT

(sorry for the delay) (In reply to comment #4) > Is prototype a name that the spec uses. If not, I would prefer we used another > name as to not conflate the term with its usage in JS. prototype is not defined in the specification but derives from the design pattern used. I agree with changing it: I propose XBLBindingElementInfo to match XBLDocumentInfo.

Julien Chaffraix

Comment 6 2008-09-24 09:12:35 PDT

David Hyatt, could you have a look at this patch? It should bring XBL closer to the structure Mozilla currently use.

Dave Hyatt

Comment 7 2008-10-10 09:44:33 PDT

Comment on attachment 22978 [details] Better changes: uses the boundDocument instead of the boundElement, restore some code changed by mistake r=me for xbl branch.

Julien Chaffraix

Comment 8 2008-10-15 09:35:38 PDT

Committed in r37603.

Note You need to log in before you can comment on or make changes to this bug.