Bug 204886 – computeIfUsingFuzzerAgent() is called before parsing command line arguments

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Tuomas Karkkainen]

computeIfUsingFuzzerAgent(); is called in the lambda inside Options::initialize() which is invoked at the top of CommandLine::parseArguments().

The options are only set later in CommandLine::parseArguments() at

> if (!JSC::Options::setOption(&arg[2])) {

This means that computeIfUsingFuzzerAgent(); will always determine that no FuzzerAgents are in use because at the time of the check all relevant options are still false regardless of the command line.

similarly I don't believe this will ever be executed either:
>     if (Options::dumpOptions()) {
>       printf("Command line:");

the thing that actually dumps the options with --dumpOptions is at the end.

[Mark Lam]

(In reply to Tuomas Karkkainen from comment #0)
> computeIfUsingFuzzerAgent(); is called in the lambda inside
> Options::initialize() which is invoked at the top of
> CommandLine::parseArguments().
> 
> The options are only set later in CommandLine::parseArguments() at
> 
> > if (!JSC::Options::setOption(&arg[2])) {
> 
> This means that computeIfUsingFuzzerAgent(); will always determine that no
> FuzzerAgents are in use because at the time of the check all relevant
> options are still false regardless of the command line.

Will fix.

> similarly I don't believe this will ever be executed either:
> >     if (Options::dumpOptions()) {
> >       printf("Command line:");
> 
> the thing that actually dumps the options with --dumpOptions is at the end.

This does run but only if you use the env var JSC_dumpOptions=true.

[Mark Lam]

Created attachment 384919 [details]
proposed patch.

[Mark Lam]

Created attachment 384921 [details]
proposed patch.

[Saam Barati]

Comment on attachment 384921 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=384921&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        computeIfUsingFuzzerAgent() is called before parsing command line arguments.

can we just go back to the world where we checked all of the options individually?

[Mark Lam]

(In reply to Saam Barati from comment #4)
> Comment on attachment 384921 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384921&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        computeIfUsingFuzzerAgent() is called before parsing command line arguments.
> 
> can we just go back to the world where we checked all of the options
> individually?

Fine.  I'll roll it out.

[Mark Lam]

Created attachment 384933 [details]
proposed patch.

[Mark Lam]

Thanks for the review.  Landed in r253164: <http://trac.webkit.org/r253164>.

[Radar WebKit Bug Importer]

<rdar://problem/57672961>