Bug 204875

Summary: Web Inspector: add compiler UNLIKELY hints when checking if developer extras are enabled
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, mkwst, msaboff, saam, timothy, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
timothy: review-
Patch none

Devin Rousso
Reported 2019-12-04 23:50:57 PST
.
Attachments
Patch (27.00 KB, patch)
2019-12-05 00:08 PST, Devin Rousso 		timothy: review-
DetailsFormatted DiffDiff
Patch (27.01 KB, patch)
2019-12-05 11:35 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-12-05 00:08:22 PST
Created attachment 384883 [details] Patch
Timothy Hatcher
Comment 2 2019-12-05 11:13:32 PST
Comment on attachment 384883 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384883&action=review > Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp:68 > + if (LIKELY(m_consoleAgent->developerExtrasEnabled())) Backwards? Should this be: if (LIKELY(!m_consoleAgent->developerExtrasEnabled())) Similar for the rest like this.
Devin Rousso
Comment 3 2019-12-05 11:35:38 PST
Created attachment 384926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384883&action=review >> Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp:68 >> + if (LIKELY(m_consoleAgent->developerExtrasEnabled())) > > Backwards? Should this be: if (LIKELY(!m_consoleAgent->developerExtrasEnabled())) > > Similar for the rest like this. Oops :|
Joseph Pecoraro
Comment 4 2019-12-06 14:54:26 PST
Comment on attachment 384926 [details] Patch r=me, Nice!
WebKit Commit Bot
Comment 5 2019-12-06 15:20:38 PST
Comment on attachment 384926 [details] Patch Clearing flags on attachment: 384926 Committed r253226: <https://trac.webkit.org/changeset/253226>
WebKit Commit Bot
Comment 6 2019-12-06 15:20:39 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-12-06 15:21:26 PST
<rdar://problem/57715465>
Note You need to log in before you can comment on or make changes to this bug.