Bug 204869 – run-javascriptcore-tests is failing to run testmasm of 64bit AppleWin on Buildbot

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Fujii Hironori]

run-javascriptcore-tests is failing to run testmasm of 64bit AppleWin on Buildbot

https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/4291

> perl ./Tools/Scripts/run-javascriptcore-tests --no-build --no-fail-fast --json-output=jsc_results.json --release --builder-name 'Apple Win 10 Release (Tests)' --build-number 4291 --buildbot-worker bot546 --buildbot-master build.webkit.org --report https://results.webkit.org
>  in dir /home/buildbot/worker/win10-release-tests/build (timeout 1200 secs)
>  watching logfiles {'json': 'jsc_results.json'}
>  argv: ['perl', './Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output=jsc_results.json', '--release', '--builder-name', 'Apple Win 10 Release (Tests)', '--build-number', '4291', '--buildbot-worker', 'bot546', '--buildbot-master', 'build.webkit.org', '--report', 'https://results.webkit.org']
>  using PTY: False
> Use of uninitialized value in concatenation (.) or string at ./Tools/Scripts/run-javascriptcore-tests line 427.
> Failed to run C:/cygwin/home/buildbot/worker/win10-release-tests/build/WebKitBuild/Release/bin64/testmasm at ./Tools/Scripts/run-javascriptcore-tests line 526.
> program finished with exit code 2
> elapsedTime=11.391830

testmasm is built if DEVELOPER_MODE is enabled.
AppleWin doesn't enable DEVELOPER_MODE.

run-javascriptcore-tests was given --no-testmasm switch for 32bit builds on Buildbot.

[Fujii Hironori]

Created attachment 384872 [details]
Patch

[Per Arne Vollan]

Comment on attachment 384872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384872&action=review

> Tools/Scripts/webkitdirs.pm:2276
> -    push @args, "-DDEVELOPER_MODE=ON" if isFTW() || isGtk() || isJSCOnly() || isWPE() || isWinCairo();
> +    push @args, "-DDEVELOPER_MODE=ON" if isJSCOnly() || isWPE() || isWin64();

Did you forget to keep isGtk()?

[Fujii Hironori]

Comment on attachment 384872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384872&action=review

>> Tools/Scripts/webkitdirs.pm:2276
>> +    push @args, "-DDEVELOPER_MODE=ON" if isJSCOnly() || isWPE() || isWin64();
> 
> Did you forget to keep isGtk()?

Yes! Thank you.

[Fujii Hironori]

Created attachment 384879 [details]
Patch for landing

[Fujii Hironori]

Committed r253142: <https://trac.webkit.org/changeset/253142>

[Radar WebKit Bug Importer]

<rdar://problem/57652630>