Bug 204864

Summary: IPC messages may get processed out of order in some cases
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, beidson, commit-queue, ggaren, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2019-12-04 16:53:52 PST
IPC messages may get processed out of order in some cases. Connection::SyncMessageState::dispatchMessages() puts messages it did not process back at the end of the queue, instead of the beginning. This means that messages added to the queue while Connection::SyncMessageState::dispatchMessages() was running will incorrectly run *before* the ones dispatchMessages() did not process.
Attachments
Patch (2.61 KB, patch)
2019-12-04 16:56 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-12-04 16:56:02 PST
Created attachment 384864 [details] Patch
Alexey Proskuryakov
Comment 2 2019-12-04 18:12:28 PST
Is this related to bug 141122?
Chris Dumez
Comment 3 2019-12-04 18:17:21 PST
(In reply to Alexey Proskuryakov from comment #2) > Is this related to bug 141122? I will check if it helps, I have not checked. I just happened to be looking at this code today for perf reasons and noticed the logic was wrong.
WebKit Commit Bot
Comment 4 2019-12-04 20:13:25 PST
Comment on attachment 384864 [details] Patch Clearing flags on attachment: 384864 Committed r253138: <https://trac.webkit.org/changeset/253138>
WebKit Commit Bot
Comment 5 2019-12-04 20:13:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-12-04 20:14:19 PST
<rdar://problem/57651997>
Note You need to log in before you can comment on or make changes to this bug.