Bug 204857

Summary: [JSC] JSWebAssemblyGlobal creation should have exception check
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2019-12-04 13:17:49 PST
[JSC] JSWebAssemblyGlobal creation should have exception check
Attachments
Patch (20.64 KB, patch)
2019-12-04 13:22 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (20.75 KB, patch)
2019-12-04 13:23 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-12-04 13:22:19 PST
Created attachment 384840 [details] Patch
Yusuke Suzuki
Comment 2 2019-12-04 13:23:48 PST
Created attachment 384841 [details] Patch
Yusuke Suzuki
Comment 3 2019-12-04 13:24:33 PST
<rdar://problem/57618579>
Mark Lam
Comment 4 2019-12-04 13:26:52 PST
Comment on attachment 384841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384841&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + in WebAssemblyModuleRecord linking phase. While exception is never thrown in this place since this happens only when WebAssembly is enabled, we should put Extra space between "in WebAssemblyModuleRecord".
Yusuke Suzuki
Comment 5 2019-12-04 13:49:59 PST
Comment on attachment 384841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384841&action=review >> Source/JavaScriptCore/ChangeLog:10 >> + in WebAssemblyModuleRecord linking phase. While exception is never thrown in this place since this happens only when WebAssembly is enabled, we should put > > Extra space between "in WebAssemblyModuleRecord". Fixed.
Yusuke Suzuki
Comment 6 2019-12-04 13:51:10 PST
Committed r253121: <https://trac.webkit.org/changeset/253121>
Note You need to log in before you can comment on or make changes to this bug.